Skip to content

Improve consistency of SGE cluster object with other clusters#421

Closed
kathoef wants to merge 1 commit into
dask:masterfrom
kathoef:add-config-name-variable-to-sge-cluster
Closed

Improve consistency of SGE cluster object with other clusters#421
kathoef wants to merge 1 commit into
dask:masterfrom
kathoef:add-config-name-variable-to-sge-cluster

Conversation

@kathoef

@kathoef kathoef commented Apr 30, 2020

Copy link
Copy Markdown
Member

I tried to access *Cluster.config_name for all available clusters during a test scenario currently developed here. This was possible for all clusters, except SGE. To have the cluster objects consistent the attribute should be added, I think.

@willirath

Copy link
Copy Markdown
Collaborator

Looks like an opportunity to try team mentions:

@dask/sge, this one is for you.

@lesteve

lesteve commented May 4, 2020

Copy link
Copy Markdown
Member

Looks like this was some forgotten clean-up from #366 and cluster classes are not supposed to have the config_name class parameter ...

If you need it from the cluster class, you can use self.job_cls.default_config_name().

I am going to close this one and merge #426 instead.

@lesteve lesteve closed this May 4, 2020
@kathoef

kathoef commented May 4, 2020

Copy link
Copy Markdown
Member Author

Great, that looks like a better thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants